Conversation
haynesjm42
reviewed
Mar 19, 2024
Member
haynesjm42
left a comment
haynesjm42
left a comment
There was a problem hiding this comment.
Looks good! We might consider an example using the query params form for route parameters as I think that is fairly common, and allows the parameters to be optional so you don't need to create the child route
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
jacob-xhio
force-pushed
the
routing-tabs
branch
from
d764ef5 to
9bb2dd1
Compare
… changes before grid load
amcclain
reviewed
Mar 26, 2024
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
amcclain
reviewed
Mar 26, 2024
Member
amcclain
left a comment
amcclain
left a comment
There was a problem hiding this comment.
A few minor comments below - should be quick to look through then let's get it merged 👍
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the simple case of the following issue: #458. A video sample of the functionality working is shown below, along with a screenshot of the final appearance of the tab.
Video:
https://github.com/xh/toolbox/assets/163027616/ca767af9-3d72-41dc-9d40-84c6de2318ca