Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct request validation #963

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

GG2002
Copy link

@GG2002 GG2002 commented Aug 25, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    [Bug]: check_intervals will not validate correctly in certain nested txn scenarios #410
  • what changes does this pull request make?
    Corrected the behavior of request validation. Please refer to this proposal for the general idea. The specific code behavior is slightly different from what is stated in the proposal, but the idea of finding out LCA is the same.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

Reopen #942

@mergify mergify bot requested a review from a team August 25, 2024 09:09
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (e35b35a) to head (6f6798c).
Report is 192 commits behind head on master.

Files Patch % Lines
crates/xlineapi/src/request_validation.rs 87.95% 6 Missing and 4 partials ⚠️
crates/utils/src/lca_tree.rs 93.81% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   75.55%   75.85%   +0.30%     
==========================================
  Files         180      188       +8     
  Lines       26938    27990    +1052     
  Branches    26938    27990    +1052     
==========================================
+ Hits        20353    21233     +880     
- Misses       5366     5451      +85     
- Partials     1219     1306      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot requested a review from a team August 25, 2024 11:29
@GG2002 GG2002 closed this Aug 25, 2024
@GG2002 GG2002 force-pushed the correct-request-validation branch from 70228ca to 62088fc Compare August 25, 2024 11:42
@GG2002 GG2002 reopened this Aug 25, 2024
@bsbds bsbds merged commit 878a202 into xline-kv:master Aug 25, 2024
26 checks passed
@GG2002 GG2002 deleted the correct-request-validation branch August 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants