-
-
Notifications
You must be signed in to change notification settings - Fork 481
quantlib: update to 1.40 #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
quantlib: update to 1.40 #8398
Conversation
Summary of ChangesHello @Willaaaaaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the QuantLib package to version 1.40, and also adds version 1.39. The changes correctly address a build failure by specifying the required Boost library components. Additionally, the C++ standard is now dynamically selected based on the QuantLib version, which is a great improvement for maintainability. My review includes one high-severity suggestion to refine the list of Boost components to better align with QuantLib's official build requirements, ensuring a more robust and correct build.
Currently,
xrepo install quantlib
will fail due to missinngboost
headers.This PR added necessary components of the boost library.
related prs: #5553 #6217 #7142 #7811 #8395