Skip to content

Conversation

Willaaaaaaa
Copy link
Contributor

@Willaaaaaaa Willaaaaaaa commented Oct 16, 2025

Currently, xrepo install quantlib will fail due to missinng boost headers.
This PR added necessary components of the boost library.
related prs: #5553 #6217 #7142 #7811 #8395

Copy link
Contributor

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the quantlib package to its latest version, 1.40, and addresses a critical dependency issue related to Boost headers. By explicitly defining the required Boost components, it ensures that the quantlib package can be installed successfully. Additionally, the testing configuration has been refined to dynamically select the appropriate C++ standard based on the QuantLib version, improving compatibility and robustness.

Highlights

  • QuantLib Version Update: The QuantLib package has been updated to version 1.40, with version 1.39 also being added to the available versions.
  • Boost Dependency Fix: Specific Boost library components (math, container, serialization, regex, thread) have been explicitly added as dependencies to resolve issues with missing Boost headers during xrepo install quantlib.
  • Conditional C++ Standard for Testing: The C++ standard used for testing has been made conditional; it now uses C++17 for QuantLib versions 1.36 and above, and C++14 for older versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the QuantLib package to version 1.40, and also adds version 1.39. The changes correctly address a build failure by specifying the required Boost library components. Additionally, the C++ standard is now dynamically selected based on the QuantLib version, which is a great improvement for maintainability. My review includes one high-severity suggestion to refine the list of Boost components to better align with QuantLib's official build requirements, ensuring a more robust and correct build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant