Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds version v7.0 to the tinycbor package configuration. However, the reviewer pointed out that this version does not exist in the upstream repository, which will lead to a 404 error when attempting to download the source.
| add_urls("https://github.com/intel/tinycbor/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/intel/tinycbor.git") | ||
|
|
||
| add_versions("v7.0", "8b1b76001b9f987677f2ea7aa814fba1f810ff6cbbffa62ea3bac612c55b1a56") |
Contributor
There was a problem hiding this comment.
The version v7.0 does not exist in the upstream intel/tinycbor repository. The latest official release is v0.6.0. This version addition appears to be an error from an automated update tool and will result in a 404 error when attempting to download the source. Please verify the version and the corresponding SHA-256 hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of tinycbor detected (package version: v0.6.1, last github version: v7.0)