Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for version v3.0.0 of the ogre-next package. A critical issue was identified where the new version's directory structure conflicts with an existing file replacement workaround, which will likely lead to build failures.
|
|
||
| add_urls("https://github.com/OGRECave/ogre-next/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/OGRECave/ogre-next.git") | ||
| add_versions("v3.0.0", "7818085243018178730bdbe85a84d358e49b3b19e3ff65e02d33b008e778210d") |
There was a problem hiding this comment.
The addition of version v3.0.0 will likely cause the installation to fail because of the global io.replace call on line 28. In Ogre-Next 3.0.0, the directory structure has changed, and the file Components/Hlms/Pbs/src/IrradianceField/OgreIrradianceField.cpp no longer exists at that path (the IrradianceField subdirectory was removed). This workaround should be restricted to version v2.2.5 or updated to the correct path for 3.0.0 to avoid build errors.
1 participant
New version of ogre-next detected (package version: v2.2.5, last github version: v3.0.0)