Conversation
There was a problem hiding this comment.
Code Review
This pull request adds version 14.2.0 to the harfbuzz package. A review comment identifies a checksum mismatch: the provided hash corresponds to the official .tar.xz release, whereas the package configuration defaults to a .tar.gz archive. To prevent installation failure, it is recommended to specify the correct release URL for this version.
| add_urls("https://github.com/harfbuzz/harfbuzz/archive/refs/tags/$(version).tar.gz", {excludes = "**/README", "**/test"}) | ||
| add_urls("https://github.com/harfbuzz/harfbuzz.git") | ||
|
|
||
| add_versions("14.2.0", "c652d5d94971031654ab3989891a490a895d3e3f2b71171c62692b28e94b1b93") |
There was a problem hiding this comment.
The SHA256 hash provided (c652d5d9...) corresponds to the official harfbuzz-14.2.0.tar.xz release asset, but the package is currently configured to download the GitHub-generated 14.2.0.tar.gz archive (line 6). These files have different checksums, which will cause the installation to fail. It is recommended to specify the official release URL for this version to match the hash.
add_versions("14.2.0", "c652d5d94971031654ab3989891a490a895d3e3f2b71171c62692b28e94b1b93", {url = "https://github.com/harfbuzz/harfbuzz/releases/download/14.2.0/harfbuzz-14.2.0.tar.xz"})
New version of harfbuzz detected (package version: 13.1.1, last github version: 14.2.0)