check for font open errors #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may not have been done because `throwIfNull` can't be used directly. A wrapper using `coerce` works, though. Prevents xmonad from dumping core in `XMonad.Prompt.printPrompt` if an invalid font is specified.
|
BTW, |
Users will need to know that they need to check for exceptions.
|
@liskin , as most recent maintainer, are we okay to bump the version and then make xmonad depend on it? Do you think we need a major version bump for anyone else who might be using it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not have been done because
throwIfNullcan't be used directly. A wrapper usingcoerceworks, though. Prevents xmonad from dumping core inXMonad.Prompt.printPromptif an invalid font is specified.