Merge pull request #874 from ulrikdem/ezconfig-duplicate

X.U.EZConfig: Fix checkKeymap warning that all keybindings are duplicate
xmonad · Feb 16, 2024 · c8dff5e · c8dff5e
2 parents 93ad0ef + aec2186
commit c8dff5e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -10,6 +10,10 @@
 
   * Fix build-with-cabal.sh when XDG_CONFIG_HOME is defined.
 
+  * `XMonad.Util.EZConfig`
+
+    - Fixed `checkKeymap` warning that all keybindings are duplicates.
+
 ### Other changes
 
 ## 0.18.0 (February 3, 20

diff --git a/XMonad/Util/EZConfig.hs b/XMonad/Util/EZConfig.hs
@@ -552,8 +552,8 @@ doKeymapCheck :: XConfig l -> [(String,a)] -> ([String], [String])
 doKeymapCheck conf km = (bad,dups)
   where ks = map ((readKeySequence conf &&& id) . fst) km
         bad = nub . map snd . filter (isNothing . fst) $ ks
-        dups = map (snd . NE.head)
-             . mapMaybe nonEmpty
+        dups = map (snd . NE.head . notEmpty)
+             . filter ((>1) . length)
              . groupBy ((==) `on` fst)
              . sortBy (comparing fst)
              . map (first fromJust)