only sink window if actually fullscreened #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
slotThe
approved these changes
Jan 19, 2024
liskin
reviewed
Jan 19, 2024
XMonad/Hooks/EwmhDesktops.hs
Outdated
| @@ -548,7 +548,7 @@ fullscreenEventHook' | |||
| when (action == add || (action == toggle && not isFull)) $ do | |||
There was a problem hiding this comment.
Hm, do we perhaps want to make the same change here to prevent windows from being fullscreened multiple times if a rogue app makes multiple add requests?
There was a problem hiding this comment.
I left that one alone because it seems to be idempotent.
There was a problem hiding this comment.
But we have no idea what fullscreenHook does so it's only idempotent with the default one.
`EwmhFullscreen` unconditionally sinks windows in response to a `_NET_WM_STATE` root window message removing `_NET_WM_STATE_FULLSCREEN`. Unfortunately, at least some versions of either the Gtk or GNOME libraries send this on startup while restoring a window's last known state, which means a `manageHook` `doFloat` will be undone. This change ignores the remove if the window is not fullscreen. A followup issue, xmonad#865, has been added for the follow-on problem that the floating state of a window is not restored on removal of the fullscreen state. Fixes: xmonad#820
geekosaur
force-pushed
the
820-ewmhFullscreen-sink
branch
from
721466c
to
545218e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EwmhFullscreenunconditionally sinks windows in response to a_NET_WM_STATEroot window message removing_NET_WM_STATE_FULLSCREEN. Unfortunately, at least some versions of either the Gtk or GNOME libraries send this on startup while restoring a window's last known state, which means amanageHookdoFloatwill be undone.This change ignores the remove if the window is not fullscreen.
A followup issue, #865, has been added for the follow-on problem that the floating state of a window is not restored on removal of the fullscreen state.
Closes: #820
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: a user is already using this change successfully
I updated the
CHANGES.mdfile (unnecessary)