X.A.UpKeys: Init #900
Merged
X.A.UpKeys: Init #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original implementation from https://stackoverflow.com/a/11308086
slotThe
commented
Aug 22, 2024
| Next, define the keys and actions you want to have happen on the release | ||
| of a key: | ||
|
|
||
| > myUpKeys = ezUpKeys $ |
There was a problem hiding this comment.
There are, I guess, a million ways one could go about implementing this. Do we ask users to specify whether they want the key grabbed for every key (possibly with a global default fallback)? Do we also accept bindings for key presses here, so that one doesn't need to "split" the functionality across different parts of the config? I haven't thought too much about this, and just went with the most obvious one. Open for opinions
geekosaur
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've known about this stackoverflow post for a while, but seemingly the code has never made it to contrib. I think that it could come in handy once in a while, so why not add it?
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: I tested the extended example and things seem to work nicely; no actual tests (yet‽)
I updated the
CHANGES.mdfileTODO