Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to root #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

redirect to root #5

wants to merge 1 commit into from

Conversation

scopatz
Copy link
Member

@scopatz scopatz commented Oct 19, 2020

rather than contents. CC @xonsh/xore

@laloch
Copy link
Member

laloch commented Oct 19, 2020

Looks good to me. We already know, that @anki-code doesn't like the new landing page. I do...

@scopatz
Copy link
Member Author

scopatz commented Oct 19, 2020

Yeah, I think he might be outvoted on the landing page. He is the only one I have heard from in any venue who doesn't like the landing page. 🤷

@anki-code
Copy link
Member

anki-code commented Oct 19, 2020

Hah, I was heard! It's the good news :) But I'm one it's the bad news :)

Meanwhile I pushed the path to the content not because I don't like spongebob landing :) The old pages (index.html excluded) are from documentation. And the user who click on "Environment Variables - 0.4 xonsh" in Google expects to see the documentation and not the landing page.

The ideal way is to save the path and redirect envvars to new envvars.

Screenshot_20201019_231823

PS: the new landing page is like cookiecutter plugin (before my changes) - it exists but not working :P

@scopatz
Copy link
Member Author

scopatz commented Oct 19, 2020

The ideal way is to save the path and redirect envvars to new envvars.

Yeah, I agree that would be best

@anki-code
Copy link
Member

I suggest to save the current solution (redirect to contents). In couple of weeks the old pages will go from the search index. It's no needed to spend time for it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants