-
Notifications
You must be signed in to change notification settings - Fork 3
[TA-5032]: ibc testsuite #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c24154f
feat(cosmos): adaptint `@cosmjs` to support `EthAccount`
GuillemGarciaDev 622e4ea
feat(cosmos): template mainnet config
GuillemGarciaDev 97320f0
Merge branch 'main' into cosmos/feat/ibc-testsuite
AdriaCarrera ea7cc43
feat: update Cosmos network configurations and dependencies
AdriaCarrera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "require": ["ts-node/register"], | ||
| "spec": "test/**/*.test.ts", | ||
| "timeout": 15000 | ||
| "timeout": 1000000 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { Account, accountFromAny } from "@cosmjs/stargate"; | ||
| import { Any } from "cosmjs-types/google/protobuf/any"; | ||
| import { parseEthAccount } from "./parser"; | ||
|
|
||
| /** | ||
| * Custom account parser that extends accountFromAny to support EthAccount format. | ||
| * This parser handles both standard Cosmos accounts and Ethermint EthAccount types. | ||
| * | ||
| * Supports the EthAccount format as defined in ethermint.types.v1: | ||
| * ```proto | ||
| * message EthAccount { | ||
| * cosmos.auth.v1beta1.BaseAccount base_account = 1; | ||
| * string code_hash = 2; | ||
| * } | ||
| * ``` | ||
| * @param input The Any message containing the account. | ||
| * @returns The parsed account. | ||
| * @throws Error if parsing fails for both EthAccount and standard account formats. | ||
| */ | ||
| export function ethermintAccountParser(input: Any): Account { | ||
| try { | ||
| // Handle EthAccount specifically | ||
| if (input.typeUrl === "/ethermint.types.v1.EthAccount") { | ||
| const ethAccount = parseEthAccount(input); | ||
| if (ethAccount?.baseAccount) { | ||
| return { | ||
| address: ethAccount.baseAccount.address, | ||
| accountNumber: Number(ethAccount.baseAccount.accountNumber), | ||
| sequence: Number(ethAccount.baseAccount.sequence), | ||
| pubkey: null, // EthAccount doesn't store pubkey in the account | ||
| } as Account; | ||
| } | ||
| // If EthAccount parsing fails, fall through to standard parsing | ||
| } | ||
|
|
||
| // For all other account types or if EthAccount parsing failed, use standard parsing | ||
| return accountFromAny(input); | ||
| } catch (error) { | ||
| console.error("Failed to parse account with ethermintAccountParser:", error); | ||
| // Final fallback to standard parsing, let it throw if it fails | ||
| return accountFromAny(input); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Check if an account type URL represents an EthAccount. | ||
| * @param typeUrl The type URL to check. | ||
| * @returns True if the type URL is for an EthAccount. | ||
| */ | ||
| export function isEthAccount(typeUrl: string): boolean { | ||
| return typeUrl === "/ethermint.types.v1.EthAccount"; | ||
| } | ||
|
|
||
| /** | ||
| * Create an account parser specifically for Ethermint/Evmos chains. | ||
| * This is a factory function that returns a configured account parser. | ||
| * @returns The account parser function. | ||
| */ | ||
| export function createEthermintAccountParser() { | ||
| return (input: Any): Account => ethermintAccountParser(input); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could define a ParserError/IBCParserError error class