close #95; do not use chomp() in modules

xslate · Nov 16, 2013 · 92c7387 · 92c7387
1 parent 06487ea
commit 92c7387
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/Text/Xslate/Parser.pm b/lib/Text/Xslate/Parser.pm
@@ -281,7 +281,7 @@ sub auto_chomp {
         #       \n        <:- ...  :>
         #       ^^^^^^^^^^
         $p->[1] = '';
-        $nl += chomp ${$s_ref};
+        $nl += (${$s_ref} =~ s/\n\z//xms);
     }
     return $nl;
 }
@@ -412,7 +412,7 @@ sub preprocess {
             if($s =~ /\A \s* [}] \s* \z/xms){
                 $code .= $s;
             }
-            elsif(chomp $s) {
+            elsif($s =~ s/\n\z//xms) {
                 $code .= qq{$s\n};
             }
             else {

diff --git a/t/900_bugs/039_issue95.t b/t/900_bugs/039_issue95.t
@@ -0,0 +1,23 @@
+#!perl
+use strict;
+use warnings;
+
+use Test::More;
+
+use Text::Xslate::Syntax::Kolon;
+
+{
+    my $content = <<'T';
+: cascade bar {
+:     hoge => 'fuga'
+: }
+T
+    my $parser = Text::Xslate::Syntax::Kolon->new();
+
+    local $/;
+    $parser->parse($content);
+}
+
+pass;
+
+done_testing;