-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gh-workflow): Include task files as dependencies in build_wheels
workflow to trigger runs on changes.
#125
fix(gh-workflow): Include task files as dependencies in build_wheels
workflow to trigger runs on changes.
#125
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build_wheels.yml (1)
23-23
: LGTM! Consider documenting the task files' purpose.The mirrored configuration for push events is correct. Consider adding a comment in the workflow file to document why these task files are essential dependencies.
Add a comment above the paths section:
pull_request: + # Paths that trigger the workflow: + # - Task files: Configuration for linting and development tasks paths:Also applies to: 28-28
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build_wheels.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: linters
🔇 Additional comments (1)
.github/workflows/build_wheels.yml (1)
10-10
: LGTM! Verify the task files exist in the repository.The addition of task files to the trigger paths is correct and properly formatted.
Let's verify these files exist in the repository:
Also applies to: 15-15
✅ Verification successful
Task files exist and are correctly referenced
The workflow changes correctly reference both
lint-tasks.yml
andTaskfile.yml
, which exist at the repository root.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the task files exist in the repository # Expected: Both files should exist at the repository root fd -t f -e yml '^(lint-tasks|Taskfile)\.yml$'Length of output: 75
Description
Before this PR, task files are not included in the build wheel workflow. This causes a problem that the workflow (in particular, the linting workflow) is not triggered when the task files are changed.
This PR fixes the problem by properly including task files as dependencies in the
build_wheels
workflow.Validation performed
build_wheels
workflow as expected.Summary by CodeRabbit