Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Taskfile tasks to lint YAML files. #9

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Jan 18, 2025

Description

This PR sets up the basic task configuration files and linting tasks for Yaml files.
Note that for the task file naming convention, lowercase filenames are used, and the suffix .yaml is used. This is consistent with the practice applied in spider.

Additionally:

  • Apart from the top-level task file, all helper task files will be placed in the tasks/ directory.
  • Yaml attributes that are lists now consistently use hyphens across multiple lines instead of square brackets on one line.

Validation performed

  • The linting process for Yaml files completes successfully.

Copy link
Member

@davidlion davidlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the comments lets make 2 changes:

  1. rename the directory tasks/ to taskfiles/
  2. drop the -tasks suffix inside this directory (e.g. rename lint-tasks.yaml to lint.yaml)

@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion January 21, 2025 18:22
@LinZhihao-723 LinZhihao-723 merged commit 775d614 into y-scope:main Jan 22, 2025
@Bill-hbrhbr Bill-hbrhbr deleted the add-yaml-lint branch February 3, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants