Add patch support to upgrade-interactive #6492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick note, it doesn't yet support cascading patches |
johnf
force-pushed
the
upgrade-interactive-patch
branch
from
ccefe7e
to
d4fa782
Compare
|
Friendly bump. Yarn patching is really not good compared to patch-package :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
yarn upgrade-interactivedoes not currently support patches. It will always think a patch is upgradable even if no new version exists. Where there is a new version, the patch is lost from the resolutions and not reapplied.I thought I saw an issue for this once upon a time, but I can't find it anymore.
...
How did you fix it?
I've updated the interactive plugin. During the suggestion creation, I check if the spec uses the patch protocol. If it is, I unpack the version from the patch and pass that to the relevant functions. I then recreate the patch spec to apply to the new version.
...
Checklist