fix(plugin-essentials): handle aliased dependencies on dedupe #6527
+32
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I wasn't able to reliably reproduce the problem but I think you can see what was the issue from the patches.
When running a dedupe on a project with aliased dependencies (usually esbuild and esbuild-wasm for us), we experienced Yarn abruptly stopping the dedupe process with this error message:
The hash depends on the resolution but I believe it is happening because Yarn is trying to find a version of aliased dependency on original package (like trying to find esbuild-wasm on esbuild idents).
Fixes #6176.
...
How did you fix it?
Instead of trusting the descriptor's ident,
dedupeUtils
will now look up theproject.originalPackages
first to find potentially aliased packages. I tried usingproject.storedPackages
first but it was empty on runtime....
Checklist