Skip to content

Conversation

@kexiongliu123
Copy link
Contributor

RELEASE NOTES:
This change updates headerMapper.FromHTTPHeaders to preserve tracing headers such as uber-trace-id and uberctx-* even when they are not prefixed with Rpc-Header-. These headers are critical for baggage and trace context propagation in services using the new tracing interceptor. Additionally, unit tests in header_test.go are updated to assert correct preservation and round-trip conversion of both application and tracing headers. This ensures that services like Cinnamon can properly extract context even when the outbound tracing interceptor is disabled.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kexiongliu123
❌ kl943
You have signed the CLA already but the status is still pending? Let us recheck it.

// Tracing header keys that must be preserved in HTTP headers.
const (
UberTraceIDHeader = "uber-trace-id"
UberCtxHeader = "uberctx-"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't really like that uber-specific stuff is here, but we're using deprecated open source library that has all these constants, so we basically partially merging that library inside a yarpc-go. And eventually we'll get rid of outdated dependency.

(It's not an call-to-action comment, just leaving it here for the history.)

Copy link
Collaborator

@biosvs biosvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can move to testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants