-
Notifications
You must be signed in to change notification settings - Fork 116
Preserve tracing headers during FromHTTPHeaders conversion #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
| // Tracing header keys that must be preserved in HTTP headers. | ||
| const ( | ||
| UberTraceIDHeader = "uber-trace-id" | ||
| UberCtxHeader = "uberctx-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't really like that uber-specific stuff is here, but we're using deprecated open source library that has all these constants, so we basically partially merging that library inside a yarpc-go. And eventually we'll get rid of outdated dependency.
(It's not an call-to-action comment, just leaving it here for the history.)
biosvs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you can move to testing
RELEASE NOTES:
This change updates headerMapper.FromHTTPHeaders to preserve tracing headers such as uber-trace-id and uberctx-* even when they are not prefixed with Rpc-Header-. These headers are critical for baggage and trace context propagation in services using the new tracing interceptor. Additionally, unit tests in header_test.go are updated to assert correct preservation and round-trip conversion of both application and tracing headers. This ensures that services like Cinnamon can properly extract context even when the outbound tracing interceptor is disabled.