Skip to content

Changes for native posix builds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-hl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Changes for native posix builds #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9518bcb
Update native posix configs
chris-hl Oct 28, 2022
b7b953c
Fix native posix builds
chris-hl Oct 28, 2022
6f260ec
Convert all conf files to minimal form
chris-hl Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions prj_native_posix.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,39 @@
CONFIG_MAIN_THREAD_PRIORITY=3

@yashi yashi Oct 28, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind explaining to me why the main thread must be priority 3?

@chris-hl chris-hl Oct 30, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONFIG_MAIN_THREAD_PRIORITY=3
comes directly from the original prj.conf file of the micro_ros_zephyr_module application.

There was no indication why it was set to that value in the original project.
I had no reason to change it so left it as is.

CONFIG_MAIN_STACK_SIZE=25000

#CONFIG_POSIX_API=y
#CONFIG_PICOLIBC=y

@yashi yashi Oct 28, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove them.

@chris-hl chris-hl Oct 30, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do - I will convert all the prj_XXX.conf files to their minimal form.

CONFIG_PTHREAD_IPC=n

@yashi yashi Oct 28, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is default n if !POSIX_API. Why do we need this?

@chris-hl chris-hl Oct 30, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will convert all the prj_XXX.conf files to their minimal form.


CONFIG_CPLUSPLUS=y
CONFIG_MICROROS_AGENT_IP="192.168.1.42"
CONFIG_MICRO_XRCE_DDS_CLIENT_CUSTOM=y

CONFIG_LOG=y

CONFIG_NETWORKING=y
CONFIG_NET_UDP=y
CONFIG_NET_IPV4=y
CONFIG_NET_IPV6=n
CONFIG_NET_LOG=y
CONFIG_NET_STATISTICS=y

CONFIG_NET_PKT_RX_COUNT=32
CONFIG_NET_PKT_TX_COUNT=32
CONFIG_NET_BUF_RX_COUNT=32
CONFIG_NET_BUF_TX_COUNT=32

CONFIG_NET_MAX_CONTEXTS=10

CONFIG_NET_SHELL=y

CONFIG_NET_CONFIG_SETTINGS=y
CONFIG_NET_CONFIG_NEED_IPV4=y
CONFIG_NET_CONFIG_MY_IPV4_ADDR="192.0.2.1"
CONFIG_NET_CONFIG_PEER_IPV4_ADDR="192.0.2.2"

CONFIG_NET_L2_ETHERNET=y

#CONFIG_ETH_DRIVER=y
CONFIG_ETH_NATIVE_POSIX=y

38 changes: 38 additions & 0 deletions prj_native_posix_64.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,39 @@
CONFIG_MAIN_THREAD_PRIORITY=3
CONFIG_MAIN_STACK_SIZE=25000

#CONFIG_POSIX_API=y
#CONFIG_PICOLIBC=y
CONFIG_PTHREAD_IPC=n

CONFIG_CPLUSPLUS=y
CONFIG_MICROROS_AGENT_IP="192.168.1.42"
CONFIG_MICRO_XRCE_DDS_CLIENT_CUSTOM=y

CONFIG_LOG=y

CONFIG_NETWORKING=y
CONFIG_NET_UDP=y
CONFIG_NET_IPV4=y
CONFIG_NET_IPV6=n
CONFIG_NET_LOG=y
CONFIG_NET_STATISTICS=y

CONFIG_NET_PKT_RX_COUNT=32
CONFIG_NET_PKT_TX_COUNT=32
CONFIG_NET_BUF_RX_COUNT=32
CONFIG_NET_BUF_TX_COUNT=32

CONFIG_NET_MAX_CONTEXTS=10

CONFIG_NET_SHELL=y

CONFIG_NET_CONFIG_SETTINGS=y
CONFIG_NET_CONFIG_NEED_IPV4=y
CONFIG_NET_CONFIG_MY_IPV4_ADDR="192.0.2.1"
CONFIG_NET_CONFIG_PEER_IPV4_ADDR="192.0.2.2"

CONFIG_NET_L2_ETHERNET=y

#CONFIG_ETH_DRIVER=y
CONFIG_ETH_NATIVE_POSIX=y