Release source critical array before throwing OOM in LZ4JNI - #124
Merged
Merged
Conversation
LZ4_compress_limitedOutput, LZ4_compressHC, LZ4_decompress_fast and LZ4_decompress_safe returned without releasing the source array when acquiring the destination failed, and threw the OutOfMemoryError from inside the critical region. Release the source first, as the _fastReset variants already do. Fixes #83 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
In
LZ4_compress_limitedOutput,LZ4_compressHC,LZ4_decompress_fastandLZ4_decompress_safe, theout == NULLbranch now releases the source critical array before callingthrow_OOM. The_fastResetfunctions already did this. Before, this path leaked the source critical array and calledThrowNewinside a critical region.The branch isn't reachable in a unit test, because HotSpot pins arrays and doesn't fail
GetPrimitiveArrayCritical. Instead,LZ4Test,LZ4FastResetTestandLZ4FactoryTestwere run against the rebuilt native library to check that the normal path still works. All passed.🤖 Generated with Claude Code