-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Racerd #1212
Update Racerd #1212
Conversation
The test shows what I'm worried about. Even the most recent version of racerd can't compile under newest Rust compilers. This can be solved by updating its dependencies in the Cargo.toml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good, except for the failing tests.
Here's the branch for RLS support https://github.com/micbou/ycmd/commits/rust-language-server
The problem is that tests on Windows are very flaky, if I remember @micbou's words correctly.
Reviewed 1 of 1 files at r1, 5 of 5 files at r2.
Reviewable status: 0 of 2 LGTMs obtained
Merged the PR you linked @fandahao17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you installed rust-src
and set RUST_SRC_PATH
, because it broke the tests.
Reviewed 4 of 4 files at r3.
Reviewable status: 0 of 2 LGTMs obtained
Sorry for so many failed commits. I mistakenly thought the tests failed because of the lack of rust-src.However, I finally found that there may be some problems with our tests. As the error message indicates, the completion requests that were supposed to fail ended up getting a successful completion result. This may be caused by racer automatically detecting Rust sys root location ( discussed here and here, which was introduced after these tests were written. As a consequence, the 4 tests with
will not actually change the Rust sysroot value. |
So... Appveyor failure is a flake. CircleCI I don't know what it is about, perhaps another flake.
Just removing the tests to get a passing build would be wrong. If I understand correctly, latest racerd doesn't need |
|
Hi there!
I know that ycmd is migrating rust completer to RLS, but the Racerd version that ycmd currently uses is too old (last update 2 years ago) and doesn't work well under recent Rust versions (most times no completion pops up after pressing ' . ', not recognizing some Rust 2018 features, etc.). So it's necessary to switch to the most recent Racerd version before we finally migrate to RLS.
Since starting from version 2.1, racer needs nightly rust, I also added "nightly" in build scripts, test scripts and the documentation.
But as was mentioned in the issue above, Racerd isn't under effective maintenance and its most recent version is still a little bit out of date. This pull request there tries to keep it up-to-date.
This change is