-
Notifications
You must be signed in to change notification settings - Fork 15
feat: 2dc #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 2dc #2699
Conversation
2b4b697
to
f39869d
Compare
bugbot run |
@@ -20,4 +20,15 @@ | |||
|
|||
margin-left: 5px; | |||
} | |||
|
|||
&__details-layout { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems this class is never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add to bots check for unused classes
</Text> | ||
</Text> | ||
<Flex gap={2}>{stats}</Flex> | ||
<Flex gap={GROUPS_SECTION_GAP} width="full"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd better hardcode gap
property like in other usecases of Flex component. No use in constant, cause it is needed only this place.
@@ -207,3 +207,14 @@ export const selectClusterTabletsWithFqdn = createSelector( | |||
}); | |||
}, | |||
); | |||
|
|||
export const selectBridgeInfo = createSelector( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This selector seems to be never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements Bridge mode support for the YDB Embedded UI, adding functionality to display and manage Bridge piles across various cluster interfaces. This feature allows users to view Bridge pile information when the cluster is configured in Bridge mode.
Key changes:
- Added Bridge mode detection through capabilities API with
BridgeModeEnabled
flag - Added Pile Name column support to nodes and storage tables with conditional visibility
- Added Bridge piles overview section to cluster dashboard
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/utils/constants.ts |
Fixed cluster page path constant |
tests/suites/paginatedTable/paginatedTable.ts |
Added table headers extraction method for testing |
tests/suites/cluster/ClusterPage.ts |
Added cluster page test utilities for Bridge functionality |
tests/suites/bridge/mocks.ts |
Bridge mode test mocks for capabilities, nodes, and cluster data |
tests/suites/bridge/bridge.test.ts |
Comprehensive E2E tests for Bridge mode features |
src/types/api/*.ts |
Extended API types to support Bridge mode fields |
src/store/reducers/capabilities/* |
Added Bridge mode capability detection |
src/containers/Cluster/ClusterOverview/* |
Added Bridge piles display section |
src/containers/Storage/* |
Added conditional Pile Name column support |
src/containers/Nodes/* |
Added conditional Pile Name column support |
src/components/nodesColumns/* |
Added Pile Name column component |
Various component files | Replaced hardcoded em dashes with EMPTY_DATA_PLACEHOLDER |
Stand
Closes #2694
Closes #2695
Closes #2696
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨8 ⏭️2
✨ New Tests (8)
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.35 MB | Main: 85.33 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information