Skip to content

feat: 2dc #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

feat: 2dc #2699

merged 4 commits into from
Aug 14, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Aug 12, 2025

Stand

Closes #2694
Closes #2695
Closes #2696

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
374 369 0 3 2
Test Changes Summary ✨8 ⏭️2

✨ New Tests (8)

  1. off: no Pile Name column and no group-by option (bridge/bridge.test.ts)
  2. on: shows Pile Name column (bridge/bridge.test.ts)
  3. on: shows Pile Name (bridge/bridge.test.ts)
  4. off: hides Pile Name (bridge/bridge.test.ts)
  5. on: shows Pile Name and group-by option (bridge/bridge.test.ts)
  6. off: hides Pile Name and group-by option (bridge/bridge.test.ts)
  7. off: does not show Bridge piles section (bridge/bridge.test.ts)
  8. on: shows Bridge piles section with data (bridge/bridge.test.ts)

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.35 MB | Main: 85.33 MB
Diff: +0.02 MB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot August 12, 2025 10:47
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot August 12, 2025 10:59
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot August 12, 2025 11:11
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot August 12, 2025 11:36
Copilot

This comment was marked as off-topic.

cursor[bot]

This comment was marked as outdated.

@astandrik astandrik marked this pull request as ready for review August 12, 2025 16:27
@ydb-platform ydb-platform deleted a comment from claude bot Aug 12, 2025
@astandrik
Copy link
Collaborator Author

bugbot run
/claude_review

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as off-topic.

@ydb-platform ydb-platform deleted a comment from claude bot Aug 12, 2025
@@ -20,4 +20,15 @@

margin-left: 5px;
}

&__details-layout {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this class is never used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add to bots check for unused classes

</Text>
</Text>
<Flex gap={2}>{stats}</Flex>
<Flex gap={GROUPS_SECTION_GAP} width="full">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd better hardcode gap property like in other usecases of Flex component. No use in constant, cause it is needed only this place.

@@ -207,3 +207,14 @@ export const selectClusterTabletsWithFqdn = createSelector(
});
},
);

export const selectBridgeInfo = createSelector(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selector seems to be never used

Raubzeug
Raubzeug previously approved these changes Aug 13, 2025
@astandrik astandrik requested a review from Copilot August 13, 2025 22:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Bridge mode support for the YDB Embedded UI, adding functionality to display and manage Bridge piles across various cluster interfaces. This feature allows users to view Bridge pile information when the cluster is configured in Bridge mode.

Key changes:

  • Added Bridge mode detection through capabilities API with BridgeModeEnabled flag
  • Added Pile Name column support to nodes and storage tables with conditional visibility
  • Added Bridge piles overview section to cluster dashboard

Reviewed Changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/utils/constants.ts Fixed cluster page path constant
tests/suites/paginatedTable/paginatedTable.ts Added table headers extraction method for testing
tests/suites/cluster/ClusterPage.ts Added cluster page test utilities for Bridge functionality
tests/suites/bridge/mocks.ts Bridge mode test mocks for capabilities, nodes, and cluster data
tests/suites/bridge/bridge.test.ts Comprehensive E2E tests for Bridge mode features
src/types/api/*.ts Extended API types to support Bridge mode fields
src/store/reducers/capabilities/* Added Bridge mode capability detection
src/containers/Cluster/ClusterOverview/* Added Bridge piles display section
src/containers/Storage/* Added conditional Pile Name column support
src/containers/Nodes/* Added conditional Pile Name column support
src/components/nodesColumns/* Added Pile Name column component
Various component files Replaced hardcoded em dashes with EMPTY_DATA_PLACEHOLDER

@astandrik astandrik requested a review from Raubzeug August 13, 2025 22:58
@astandrik astandrik added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit a4b737b Aug 14, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2dc branch August 14, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2DC] Groups [2DC] Nodes [2DC] Cluster
2 participants