fix(query): incorrect selector #2703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
artemmufazalov,
astandrik and
adameat
as code owners
| @@ -174,6 +166,19 @@ export const selectQueryDuration = createSelector( | |||
| }, | |||
| ); | |||
|
|
|||
| export const selectQueriesHistory = createSelector( | |||
There was a problem hiding this comment.
Please, explain, why these changes are needed? I see no difference
There was a problem hiding this comment.
Previous realization caused errors Selector wrapper returned a different result when called with the same parameters. This can lead to unnecessary rerenders. Selectors that return a new reference (such as an object or an array) should be memoized And this caused total freeze of the page.
artemmufazalov
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.33 MB | Main: 85.33 MB
Diff: +0.23 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information