Skip to content

Values comparison #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: release_v2.4.0
Choose a base branch
from

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Aug 11, 2025

No description provided.

@alex268 alex268 requested review from pnv1 and zinal August 11, 2025 09:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 91.62304% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.60%. Comparing base (af5f970) to head (2043e3c).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/tech/ydb/table/values/PrimitiveValue.java 90.74% 4 Missing and 1 partial ⚠️
...src/main/java/tech/ydb/table/values/DictValue.java 82.60% 2 Missing and 2 partials ⚠️
...src/main/java/tech/ydb/table/values/ListValue.java 85.71% 1 Missing and 1 partial ⚠️
...c/main/java/tech/ydb/table/values/StructValue.java 86.66% 1 Missing and 1 partial ⚠️
...rc/main/java/tech/ydb/table/values/TupleValue.java 86.66% 1 Missing and 1 partial ⚠️
.../main/java/tech/ydb/table/values/DecimalValue.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #523      +/-   ##
============================================
+ Coverage     61.29%   62.60%   +1.30%     
- Complexity     2306     2465     +159     
============================================
  Files           328      328              
  Lines         13468    13666     +198     
  Branches       1344     1398      +54     
============================================
+ Hits           8255     8555     +300     
+ Misses         4577     4452     -125     
- Partials        636      659      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zinal zinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zinal zinal mentioned this pull request Aug 12, 2025
@alex268 alex268 changed the base branch from master to release_v2.4.0 August 12, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants