Skip to content

add test to check metadata #17747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add test to check metadata #17747

wants to merge 3 commits into from
+40 −18

Conversation

nerhneiro
Copy link
Collaborator

Changelog entry

Add submission of metadata field in OffsetCommit() method.

Add check that metadata is not loaded from OffsetFetch() method.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nerhneiro nerhneiro requested a review from a team as a code owner April 25, 2025 14:58
@nerhneiro nerhneiro requested a review from nshestakov April 25, 2025 14:58
@github-actions GitHub Actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@nerhneiro nerhneiro marked this pull request as draft April 25, 2025 15:00
@nerhneiro nerhneiro marked this pull request as ready for review April 25, 2025 15:05
@github-actions GitHub Actions
Copy link

🟢 2025-04-25 15:06:14 UTC The validation of the Pull Request description is successful.

@a-serebryanskiy a-serebryanskiy self-requested a review April 26, 2025 16:50
@a-serebryanskiy a-serebryanskiy added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 26, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Apr 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2025 •
edited
Loading

⚪ 2025-04-26 17:05:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for f743e4b has started.
⚪ 2025-04-26 17:05:52 UTC Artifacts will be uploaded here
⚪ 2025-04-26 17:08:04 UTC ya make is running...
🟢 2025-04-26 17:14:10 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 94 0 0 0 0

🟢 2025-04-26 17:14:16 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2025 •
edited
Loading

⚪ 2025-04-26 17:06:44 UTC Pre-commit check linux-x86_64-release-asan for f743e4b has started.
⚪ 2025-04-26 17:06:59 UTC Artifacts will be uploaded here
⚪ 2025-04-26 17:09:19 UTC ya make is running...
🟡 2025-04-26 17:18:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 93 0 1 0 0

⚪ 2025-04-26 17:18:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-26 17:19:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2025-04-26 17:19:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-26 17:20:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-04-26 17:20:21 UTC Build successful.

a-serebryanskiy
a-serebryanskiy reviewed Apr 26, 2025
View reviewed changes
@a-serebryanskiy a-serebryanskiy removed the request for review from nshestakov April 26, 2025 17:39
fix codestyle
3ac54a2 
rename TConsumerOffset struct
add PartitionIndex field to TConsumerOffset struct to substitude std::pair in OffsetCommit function
a-serebryanskiy
a-serebryanskiy reviewed May 1, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 13:37:12 UTC Pre-commit check linux-x86_64-release-asan for 7c97e31 has started.
⚪ 2025-05-05 13:37:40 UTC Artifacts will be uploaded here
⚪ 2025-05-05 13:40:28 UTC ya make is running...
🟢 2025-05-05 13:49:30 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 94 0 0 0 0

🟢 2025-05-05 13:49:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 13:38:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c97e31 has started.
⚪ 2025-05-05 13:39:05 UTC Artifacts will be uploaded here
⚪ 2025-05-05 13:41:44 UTC ya make is running...
🟢 2025-05-05 13:47:37 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 94 0 0 0 0

🟢 2025-05-05 13:47:43 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-serebryanskiy a-serebryanskiy a-serebryanskiy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nerhneiro @a-serebryanskiy