add test to check metadata #17747
add test to check metadata #17747
Conversation
|
Hi! Thank you for contributing! |
|
🟢 |
a-serebryanskiy
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢 |
rename TConsumerOffset struct add PartitionIndex field to TConsumerOffset struct to substitude std::pair in OffsetCommit function
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
| for (ui64 i = 0; i < minActivePartitions; ++i) { | ||
| partitionsAndOffsets.emplace_back(std::make_pair(i, recordsCount)); | ||
| partitionsAndOffsets.emplace_back(TConsumerOffset{i, static_cast<ui64>(recordsCount), commitedMetaData}); |
There was a problem hiding this comment.
Кажется, здесь происходит ненужная лишняя инициализация структуры TConsumerOffset. Можно в качестве аргумента emplace_back просто передать аргументы конструктора, чтобы вектор сам собрал объект в нужном месте в памяти.
partitionsAndOffsets.emplace_back(i, static_cast<ui64>(recordsCount), commitedMetaData);
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
Co-authored-by: Irina Skvortsova <[email protected]>
Co-authored-by: Irina Skvortsova <[email protected]>
Changelog entry
Add submission of metadata field in OffsetCommit() method.
Add check that metadata is not loaded from OffsetFetch() method.
Changelog category
Description for reviewers
...