Skip to content

25-1-1: Limit inflight config updates #17757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Apr 25, 2025

Changelog entry

Limit internal inflight config updates.

Changelog category

  • Performance improvement

Description for reviewers

#17725

@CyberROFL CyberROFL requested a review from a team as a code owner April 25, 2025 19:28
@CyberROFL CyberROFL assigned CyberROFL and unassigned CyberROFL Apr 25, 2025
@CyberROFL CyberROFL linked an issue Apr 25, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:32:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a960df has started.
2025-04-25 19:32:58 UTC Artifacts will be uploaded here
2025-04-25 19:36:09 UTC ya make is running...
🟡 2025-04-25 20:44:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18688 17415 0 4 1207 62

2025-04-25 20:46:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-25 21:07:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 66 0 0 1 60

🟢 2025-04-25 21:07:51 UTC Build successful.
🟢 2025-04-25 21:08:26 UTC ydbd size 2.1 GiB changed* by +39.1 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 5075022 merge: 0a960df diff diff %
ydbd size 2 243 486 208 Bytes 2 243 526 264 Bytes +39.1 KiB +0.002%
ydbd stripped size 475 069 048 Bytes 475 077 112 Bytes +7.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) April 25, 2025 19:32
Copy link

github-actions bot commented Apr 25, 2025

2025-04-25 19:33:12 UTC Pre-commit check linux-x86_64-release-asan for 0a960df has started.
2025-04-25 19:33:28 UTC Artifacts will be uploaded here
2025-04-25 19:36:17 UTC ya make is running...
🟡 2025-04-25 20:47:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11802 11678 0 85 5 34

2025-04-25 20:48:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-25 21:08:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 137 0 0 1 33

🟢 2025-04-25 21:09:03 UTC Build successful.
🟢 2025-04-25 21:09:27 UTC ydbd size 3.6 GiB changed* by +67.3 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 5075022 merge: 0a960df diff diff %
ydbd size 3 902 521 888 Bytes 3 902 590 832 Bytes +67.3 KiB +0.002%
ydbd stripped size 1 365 625 872 Bytes 1 365 652 144 Bytes +25.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit cfdd066 into ydb-platform:stable-25-1-1 Apr 27, 2025
12 checks passed
@CyberROFL CyberROFL deleted the limit-inflight-config-updates-25-1-1 branch April 27, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider: limit inflight config updates
2 participants