Skip to content

Added EnableAutoDropping flag #17758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added EnableAutoDropping flag #17758

wants to merge 2 commits into from

Conversation

stanislav-shchetinin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@stanislav-shchetinin stanislav-shchetinin requested a review from a team as a code owner April 25, 2025 23:09
@github-actions GitHub Actions
Copy link

🟢 2025-04-25 23:10:18 UTC The validation of the Pull Request description is successful.

@stanislav-shchetinin stanislav-shchetinin self-assigned this Apr 25, 2025
@stanislav-shchetinin stanislav-shchetinin linked an issue Apr 25, 2025 that may be closed by this pull request
Auto-remove temporary export tables #9733
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 23:13:15 UTC Pre-commit check linux-x86_64-release-asan for 2107769 has started.
⚪ 2025-04-25 23:13:29 UTC Artifacts will be uploaded here
⚪ 2025-04-25 23:16:34 UTC ya make is running...
🟡 2025-04-26 01:07:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14716 14564 0 80 47 25

⚪ 2025-04-26 01:08:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-26 01:35:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
981 (only retried tests) 880 0 46 31 24

⚪ 2025-04-26 01:35:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-26 02:01:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
793 (only retried tests) 687 0 44 38 24

🟢 2025-04-26 02:01:50 UTC Build successful.
🟢 2025-04-26 02:02:22 UTC ydbd size 3.8 GiB changed* by +3.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 290386c merge: 2107769 diff diff %
ydbd size 4 120 274 248 Bytes 4 120 277 992 Bytes +3.7 KiB +0.000%
ydbd stripped size 1 428 517 272 Bytes 1 428 517 656 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 23:14:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2107769 has started.
⚪ 2025-04-25 23:14:43 UTC Artifacts will be uploaded here
⚪ 2025-04-25 23:17:48 UTC ya make is running...
🟡 2025-04-26 01:03:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29496 26800 0 7 2643 46

⚪ 2025-04-26 01:06:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-26 01:32:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
586 (only retried tests) 535 0 0 14 37

🟢 2025-04-26 01:32:42 UTC Build successful.
🟢 2025-04-26 01:33:01 UTC ydbd size 2.2 GiB changed* by +3.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 290386c merge: 2107769 diff diff %
ydbd size 2 342 188 048 Bytes 2 342 191 464 Bytes +3.3 KiB +0.000%
ydbd stripped size 492 592 192 Bytes 492 592 512 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL reviewed Apr 28, 2025
View reviewed changes
ydb/core/protos/feature_flags.proto
@@ -206,4 +206,5 @@ message TFeatureFlags {
optional bool SwitchToConfigV1 = 180 [default = false];
optional bool EnableEncryptedExport = 181 [default = false];
optional bool EnableAlterDatabase = 182 [default = false];
optional bool EnableAutoDropping = 183 [default = true];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из флага непонятно auto dropping чего и где? Давай хотя бы EnableExportAutoDropping.

ydb/core/tx/schemeshard/ut_export_reboots_s3/ut_export_reboots_s3.cpp
@@ -620,4 +620,41 @@ Y_UNIT_TEST_SUITE(TExportToS3WithRebootsTests) {
}
});
}

Y_UNIT_TEST(ShouldEnabledAutoDropping) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может Disable?

ydb/core/tx/schemeshard/ut_export/ut_export.cpp
@@ -150,6 +150,40 @@ namespace {
const ui64 exportId = txId;
TestGetExport(runtime, schemeshardId, exportId, dbName, expectedStatus);

if (!runtime.GetAppData().FeatureFlags.GetEnableAutoDropping() && checkAutoDropping) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему бы не унести это в конкретный тест? Зачем это в базовой функции?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@stanislav-shchetinin stanislav-shchetinin

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-remove temporary export tables
2 participants
@stanislav-shchetinin @CyberROFL