Prevent redefinition of ssize_t #2319
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirose
reviewed
Jan 5, 2026
httplib.h
Outdated
|
|
||
| #pragma comment(lib, "ws2_32.lib") | ||
|
|
||
| #ifndef HAVE_SSIZE_T |
Owner
There was a problem hiding this comment.
Could you please change it to _SSIZE_T_DEFINED, as this area is Windows- specific?
Contributor
Author
There was a problem hiding this comment.
HAVE_SSIZE_T is used by other libs for this very purpose, see wx/types.h for example. Tho for my purpose _SSIZE_T_DEFINED would work as well if you have a strong preference.
Owner
There was a problem hiding this comment.
Yes, I would like to use _SSIZE_T_DEFINED instead.
Contributor
Author
There was a problem hiding this comment.
Changed to _SSIZE_T_DEFINED
On Windows cpp-httplib defines ssize_t, therefore applications needing to define ssize_t for their own needs or are using libraries that do require a means to avoid a possible incompatible redefinition. Signed-off-by: Ralph Sennhauser <[email protected]>
seragh
force-pushed
the
prevent-ssize_t-redefiniton
branch
from
88ba116 to
b30e861
Compare
Owner
|
@seragh thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows cpp-httplib defines ssize_t, therefore applications needing to define ssize_t for their own needs or are using libraries that do require a means to avoid a possible incompatible redefinition.