Enhance middleware creation to support container-registered identifiers #111
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rustamwin
commented
Oct 23, 2025
rustamwin
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #110 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 110 114 +4
===========================================
Files 8 8
Lines 304 297 -7
===========================================
- Hits 304 297 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xepozz
requested changes
Oct 23, 2025
src/MiddlewareFactory.php
Outdated
| return is_subclass_of($definition, MiddlewareInterface::class) | ||
| || ( | ||
| $this->container->has($definition) | ||
| && $this->container->get($definition) instanceof MiddlewareInterface |
There was a problem hiding this comment.
Seems it's incorrect to build an object while checking this
Also I sugest to split this check onto two independent:
- isContainerAlias
- isMiddlewareClassDefinition
|
Docs should be expanded to include this feature. |
vjik
requested changes
Oct 23, 2025
Co-authored-by: Sergei Predvoditelev <[email protected]>
samdark
approved these changes
Oct 25, 2025
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.