Convert envelope trait to abstract class #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
samdark
approved these changes
Feb 14, 2025
xepozz
requested changes
Feb 15, 2025
| @@ -37,12 +37,4 @@ public function getMetadata(): array | |||
| { | |||
| return $this->metadata; | |||
| } | |||
|
|
|||
| public function withMetadata(array $metadata): self | |||
There was a problem hiding this comment.
I don't see any real-world use cases. Do you?
src/Message/Envelope.php
Outdated
| @@ -23,14 +20,6 @@ public function getMessage(): MessageInterface | |||
| return $this->message; | |||
| } | |||
|
|
|||
| public function withMessage(MessageInterface $message): self | |||
There was a problem hiding this comment.
I don't see any real-world use cases. Do you?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
============================================
+ Coverage 95.72% 96.55% +0.83%
+ Complexity 354 353 -1
============================================
Files 46 46
Lines 958 958
============================================
+ Hits 917 925 +8
+ Misses 41 33 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
reviewed
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.