Fix @return annotations for lastInsertId methods in yii\db\mssql namespace
#20628
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mspirkov
commented
Oct 19, 2025
mspirkov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
mspirkov
commented
Oct 19, 2025
| * Returns value of the last inserted ID. | ||
| * @param string|null $name the sequence name. Defaults to null. | ||
| * @return int last inserted ID value. | ||
| * @return string|false last inserted ID value. |
There was a problem hiding this comment.
I see that there is a conversion to bigint. It seems that regardless of the settings, the result will be string|false.
mspirkov
commented
Oct 19, 2025
| * Returns value of the last inserted ID. | ||
| * @param string|null $sequence the sequence name. Defaults to null. | ||
| * @return int last inserted ID value. | ||
| * @return string|false last inserted ID value. |
There was a problem hiding this comment.
I see that there is a conversion to bigint. It seems that regardless of the settings, the result will be string|false.
mspirkov
commented
Oct 19, 2025
| * last inserted ID (like the other PDO drivers). | ||
| * @param string|null $sequence the sequence name. Defaults to null. | ||
| * @return int last inserted ID value. | ||
| * @return string|false last inserted ID value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.