Skip to content

Erase synced picture when overwritten by non-synced picture #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsdko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Erase synced picture when overwritten by non-synced picture #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/multiplayer/game_multiplayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,11 +681,16 @@ bool Game_Multiplayer::IsPictureSynced(int pic_id, std::string_view pic_name) {
}

void Game_Multiplayer::PictureShown(int pic_id, Game_Pictures::ShowParams& params) {
// IsPictureSynced overwrites sync_picture_cache data so we have to retrieve it beforehand
bool was_synced = sync_picture_cache.count(pic_id) && sync_picture_cache[pic_id];
if (IsPictureSynced(pic_id, params.name)) {
auto& p = Main_Data::game_player;
connection.SendPacketAsync<ShowPicturePacket>(pic_id, params,
Game_Map::GetPositionX(), Game_Map::GetPositionY(),
p->GetPanX(), p->GetPanY());
} else if (was_synced) {
sync_picture_cache.erase(pic_id);
connection.SendPacketAsync<ErasePicturePacket>(pic_id);
}
}

Expand Down
Loading