Fix data races in SettingsBuilder. #1233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Reason:** - `configFileSettings` and `settingPresetSettings` caches were just global dictionaries. Data races were taken place at these points when multiple projects are generated in parallel. **Content:** - Dictionaries for caches moved to NSCache which is thread safe.
aleksproger
approved these changes
Jul 21, 2022
aleksproger
reviewed
Jul 22, 2022
| @@ -0,0 +1,37 @@ | |||
| import XcodeProj | |||
There was a problem hiding this comment.
Btw, maybe the proper place for this file is XcodeGenCore target
Because, XcodeGenKit target mostly contains public business logic, closely related to project generation
|
@yonaskolb review this PR please) Thanks in advance!) |
|
@yonaskolb, please, review this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
configFileSettingsandsettingPresetSettingscaches were just global dictionaries. Data races were taken place at these points when multiple projects are generated in parallel.Content: