Refactor PBXProjGenerator and add tests around dependency order generation #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asifmohd
force-pushed
the
add_tests_for_dependency_generation_order
branch
from
fb03d0b
to
33d1765
Compare
asifmohd
commented
Oct 28, 2020
|
|
||
| targetFileReferences[target.name] = fileReference | ||
| } | ||
| let generatedTargetResults = self.generateTargetInfo(targets: self.project.targets, aggregateTargets: self.project.aggregateTargets) |
There was a problem hiding this comment.
The motivation to move this logic to a different function was to break down the generate function into smaller functions.
And then the larger goal would be, to able to test out the generateTargetInfo function in isolation. But that requires marking the generateTargetInfo function as a public function so that it can be accessed in tests.
It seems we could make this a pure function, i.e. pass in the targets to this function, and then the function returns this struct, which we can assert on, but still need to explore how feasible it would be to write tests around this function.
So I wanted to raise this PR and gather feedback if this approach makes sense, before proceeding further.
specifically to add tests around the dependency order generation
asifmohd
force-pushed
the
add_tests_for_dependency_generation_order
branch
from
33d1765
to
4e2a2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
PBXProjGeneratorand adds a few tests around dependency generation of static libraries and bundlesThis should provide a good harness for the changes being done in PR #863. That is, these newly added tests should still pass when I rebase my branch with the changes from this PR.
I will be working on adding a few more tests in separate PRs before we can probably have the #863 change ready to be merged.