Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused @MainActor #129

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

wi-seong-cheol
Copy link
Contributor

What this PR does / why we need it:

  • In Swift 5.5, UIKit and Swift UI components are all @MainActor

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e11024) 43.07% compared to head (d326deb) 43.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   43.07%   43.07%           
=======================================
  Files         104      104           
  Lines       22958    22958           
=======================================
  Hits         9890     9890           
  Misses      13068    13068           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@humdrum humdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@humdrum humdrum merged commit ca1fbc0 into yorkie-team:main Dec 11, 2023
2 checks passed
@wi-seong-cheol wi-seong-cheol deleted the default-main-actor branch December 27, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants