Fix incorrect calculation in indexTree.treePosToPath operation
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 81.35% 81.50% +0.15%
==========================================
Files 59 59
Lines 4344 4348 +4
Branches 852 853 +1
==========================================
+ Hits 3534 3544 +10
+ Misses 547 543 -4
+ Partials 263 261 -2 ☔ View full report in Codecov by Sentry. |
raararaara
changed the title
tree.edit operation in response to issue
raararaara
changed the title
tree.edit operation in response to issuetree.edit operation
raararaara
changed the title
tree.edit operationindexTree.treePosToPath operation
chacha912
approved these changes
Feb 21, 2024
hackerwins
reviewed
Feb 21, 2024
hackerwins
reviewed
Feb 21, 2024
hackerwins
approved these changes
Feb 21, 2024
Merged
2 tasks
Merged
2 tasks
2 tasks
hackerwins
added a commit
to yorkie-team/yorkie
that referenced
this pull request
Mar 20, 2024
This commit addresses an issue arising from the tree.edit operation in response to problem with calculating the fromPath when multiple treePos represent a single index-based coordinate, leading to inaccuracies. This commit contains migration work for yorkie-team/yorkie-js-sdk#751, so detailed information can also be found there. --------- Co-authored-by: Youngteac Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This patch addresses an issue arising from the
tree.editoperation in response to problem with calculating thefromPathwhen multipletreePosrepresent a single index-based coordinate, leading to inaccuracies.Any background context you want to provide?
In some cases, a single index-based coordinate can be represented by multiple
treePos, causing complications in extracting the path. To resolve this, logic has been implemented intreePosToPathto handle cases wherechildrenconsist only of text type.Case description: In a situation where the children of
<node>consist only of text type nodes, and the "e" text Node has already been removed, an additional operation is made to remove the text "f".What are the relevant tickets?
Address #749
Checklist