Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yorkie-js-sdk v0.4.18-rc in devtools #782

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it?

Update yorkie-js-sdk v0.4.18-rc in devtools

Any background context you want to provide?

What are the relevant tickets?

Related: #760

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.47%. Comparing base (2320758) to head (73234b1).

Files Patch % Lines
src/document/document.ts 47.36% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files          59       59           
  Lines        4431     4431           
  Branches      889      889           
=======================================
  Hits         3566     3566           
  Misses        604      604           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review April 23, 2024 07:49
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hackerwins hackerwins merged commit edfd031 into main Apr 23, 2024
2 checks passed
@hackerwins hackerwins deleted the devtools-v0.4.18-rc branch April 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants