Skip to content

Commit

Permalink
Add Kafka options to yorkie-cluster and missing WriteTimeout (#1149)
Browse files Browse the repository at this point in the history
Add deployment template with configurable Kafka options and resolves
missing write timeout settings.
  • Loading branch information
emplam27 authored Feb 14, 2025
1 parent 2fa676d commit d49a4bb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 6 additions & 0 deletions build/charts/yorkie-cluster/templates/yorkie/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ spec:
"{{ .Values.yorkie.ports.profilingPort }}",
"--backend-gateway-addr",
"{{ .Values.yorkie.name }}-gateway.{{ .Values.yorkie.namespace }}.svc.cluster.local",
{{- if and .Values.yorkie.args.kafkaAddresses .Values.yorkie.args.kafkaTopic }}
"--kafka-addresses",
"{{ .Values.yorkie.args.kafkaAddresses }}",
"--kafka-topic",
"{{ .Values.yorkie.args.kafkaTopic }}",
{{- end }}
]
ports:
- containerPort: {{ .Values.yorkie.ports.rpcPort }}
Expand Down
5 changes: 3 additions & 2 deletions cmd/yorkie/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ func newServerCmd() *cobra.Command {

if kafkaAddresses != "" && kafkaTopic != "" {
conf.Kafka = &messagebroker.Config{
Addresses: kafkaAddresses,
Topic: kafkaTopic,
Addresses: kafkaAddresses,
Topic: kafkaTopic,
WriteTimeout: kafkaWriteTimeout.String(),
}
}

Expand Down

0 comments on commit d49a4bb

Please sign in to comment.