Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check client Sequence while pushpulled #503

Closed
wants to merge 1 commit into from
Closed

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Mar 30, 2023

What this PR does / why we need it:

  • Add sequence validation logic.
    • When process push changes, the client sequence has to be prevClientSeq + 1
    • If the client sends an invalid ServerSeq, Send a snapshot so that the client can try to fix it.
  • Preserve sequence numbers for the push-pull response of detach and remove API.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added the enhancement 🌟 New feature or request label Mar 30, 2023
@humdrum humdrum requested a review from hackerwins March 30, 2023 04:35
@humdrum humdrum self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #503 (055f5ce) into main (fdd62a9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   48.60%   48.60%   -0.01%     
==========================================
  Files          69       69              
  Lines        5919     5915       -4     
==========================================
- Hits         2877     2875       -2     
+ Misses       2696     2694       -2     
  Partials      346      346              
Impacted Files Coverage Δ
server/backend/database/client_info.go 68.42% <ø> (+0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins
Copy link
Member

I think we need a simple design on how to deal with this issue. For now, I will register a separate issue and close this PR. #805

@hackerwins hackerwins closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants