-
Notifications
You must be signed in to change notification settings - Fork 0
Add workflow status comment with link on label event and update through run lifecycle #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…update during run\n\n- Post an initial GitHub issue comment when the "I2PR: Resolve Issue" label webhook fires, including a link to the Workflow Run page and a hidden marker for updates\n- Modify worker orchestrator to pass jobId to workflow so the run ID matches the job ID\n- Add logic in the worker orchestrator to upsert the same status comment to reflect running/completed/failed states\n
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
We should not be using the jobId for the workflow id. They are separate things. I'm not sure how bullmq creates the jobId. It makes me think we should be standardizing ids across entities. Job id, workflow id, agent id, etc. |
|
I'm thinking the handlers might not be the right pattern now. Instead of our webhook listener "launching" a workflow or enqueing a job, perhaps we need to remap the webhook into our own event bus. But maybe that's also a lot of extra complication. Because now we're giving the handlers multiple jobs. Including the updating the GitHub issue comment with latest updates. Now that I've said that, perhaps we need to "listen" to the job status updates and make updates to the GitHub issue from there. So perhaps we need to attach a listener instead, with the GitHub issue link and the comment id. |
|
Probably don't need the hidden marker if we just have the comment id directly. |
Summary
Implementation details
Why this approach
Notes
Screens/UX
The comment looks like:
[Issue to PR] Workflow queued for auto-resolve
Status: queued
Details: https://your-app/workflow-runs/{jobId}
This same comment is updated to "running", then to "completed" or "failed" with an error message if one occurs.
Closes #1322