-
Notifications
You must be signed in to change notification settings - Fork 0
Add tech specs for Workflow Runs visibility and attribution #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion signatures and file structure)
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
youngchingjui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this generally looks OK? I couldn't look at all of it. the formatting in this diff editor is hard to read. Let's just make the change I asked for in the review comment.
| initiatorUserId?: string; // Issue to PR user id | ||
| initiatorGithubUserId?: string; // numeric GitHub user id | ||
| initiatorGithubLogin?: string; // GitHub login handle | ||
| triggerType?: "app_ui" | "webhook_label_issue" | "webhook_label_pr" | "webhook_unknown"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be combined into an actor object that might be a discriminated union of different actors, including the user, webhook, etc.
…flowRunInput and ListedWorkflowRun\n\n- Address review: https://github.com/youngchingjui/issue-to-pr/pull/1429#discussion_r2650049580\n- Replace initiatorUserId/github fields and triggerType/installationId with object\n- Note derivation for Requester and webhook extraction
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 19. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This PR adds a new technical specifications document derived from docs/internal/PRD.md.
What’s included
Highlights
Linting
Please review the function and file shapes. Implementation can follow in subsequent PRs.
Closes #1428
Update: Addressed review feedback to consolidate attribution fields into an
actorobject.Changed in docs/internal/workflow-runs-tech-specs.md:
actor:actorshape instead of separate initiator*/installationId fields.actorfor authorization and that installationId is also accessible viaactorwhen kind=="webhook".Rationale: Keeps attribution cohesive and extensible across UI, API, and workers while matching the suggestion in review.
Review comment addressed: Add tech specs for Workflow Runs visibility and attribution #1429 (comment)