Skip to content

Enable automated CI tests on push and pull requests #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youngchingjui merged 4 commits into from
Dec 30, 2025
Merged

Enable automated CI tests on push and pull requests #1442

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4742ae
ci: enable automated Jest tests on push and pull_request with concurr…
Dec 29, 2025
33da35c
lets try this
youngchingjui Dec 30, 2025
4cd3eb3
simplify runs
youngchingjui Dec 30, 2025
6bff44f
Merge branch 'main' into feature/enable-ci-tests-on-push-pr
youngchingjui Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: Run Jest Tests

# Turning off automatic runs while we re-organize our tests
on:
push:
branches:
- "**"
Copy link

@cursor cursor bot Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing pull_request trigger despite PR description

The PR description explicitly states the workflow triggers on pull_request events for all branches, but the on: block only includes push and workflow_dispatch. PRs won't automatically run the test suite as intended, defeating one of the main goals stated in the PR description.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing concurrency settings despite PR description

The PR description states "Added concurrency settings to cancel in-progress runs for the same branch" with cancel-in-progress: true, but no concurrency block exists in the workflow file. Without this, redundant workflow runs won't be cancelled, wasting self-hosted runner resources as the PR intended to prevent.

Fix in Cursor Fix in Web

workflow_dispatch:

jobs:
Expand All @@ -28,11 +30,5 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Run tests with coverage
run: pnpm test --coverage

- name: Upload coverage report
uses: actions/upload-artifact@v4
with:
name: coverage-report
path: coverage/
- name: Run tests
run: pnpm test
Copy link

@cursor cursor bot Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage and artifact upload removed despite PR claims

The PR description states the workflow will "Run Jest tests with coverage and upload artifact" and the outcome says it will "upload coverage artifacts". However, the --coverage flag and the actions/upload-artifact step were removed. This contradicts the stated intent and loses coverage tracking functionality.

Fix in Cursor Fix in Web