Repository navigation
Conversation
Collaborator
|
✅ Internal validation passed. A ZCode maintainer will review the change next; after acceptance, release checks run separately and this PR is closed automatically. |
Collaborator
|
✅ Internal validation passed. A ZCode maintainer will review the change next; after acceptance, release checks run separately and this PR is closed automatically. |
Collaborator
|
✅ Internal validation passed. A ZCode maintainer will review the change next; after acceptance, release checks run separately and this PR is closed automatically. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin type (required) / 插件类型(必填)
Affected plugin name(s) / 涉及的插件名称:
kicad(UI Plugin)What / 改动内容
auto,standard, andhuaqiuedition selection, including strict explicit-path handling and structured capability diagnostics.ToolSearch;kicad_capabilitiesnow reportsplugin_version.The plugin version is bumped to
0.12.3in the plugin manifest, UI package, andmarketplace.json.Runtime verification / 运行时验证
ToolSearch; after the fix it had 94 total / 25 KiCad tools, and the first call returnedplugin_version=0.12.3.10 errors → 1 → 0; routing converged2 unrouted → 1 → 0; final DRC was0 errors / 0 unconnected / 0 unrouted.ready_to_order=true,blocking_problems=[]and exported 11 files.(14.0, 22.0)to(14.25, 22.0), changed the signature, restored the original position/signature, and keptsaved=false. Source and edit-board SHA-256 stayed identical.Full evidence:
docs/kicad-zcode-live-ipc-acceptance.mddocs/kicad-zcode-shift-register-long-run.mddocs/kicad-zcode-composite-controller-long-run.md— 10 process screenshots, final top/bottom renders, raw PCB report/spec, and machine-readable run summary.Harness observation / Harness 观察
The same composite prompt was tried twice with GLM-5.3 Max. Both attempts spent 148 s / 139 s planning before the first tool and made zero calls, even after a steering message explicitly required
kicad_capabilitiesfirst. GLM-5.3 Low called the required first tool in about 12 s and completed 30 KiCad calls in 8m26s. The report preserves this as model/harness data rather than treating it as a plugin failure.Verification commands / 验证命令
pnpm install --frozen-lockfile— passedpnpm --dir ui-plugins/kicad build— passedpnpm --dir ui-plugins/kicad test— 22/22 passedpnpm build— passedpython3 scripts/validate.py— 52 plugins validatedpython3 scripts/build_dist.py— passed; KiCad ZIP SHA-256 prefix18d4cf4f3a4dgit diff --check— cleanpnpm test,pnpm typecheck, andpnpm lintpassed (one pre-existing craft-runtime lint warning).Self-check / 自查清单
external_plugins/<name>/; existing fixes retain ownership / 插件名唯一且 kebab-case,外部新增插件位于external_plugins/<name>/,已有插件修复保留原归属categoryis set independently of publisher ownership / 用途分类category已填写,与维护归属分开versionbumped in BOTHplugin.jsonandmarketplace.json(artifacts are immutable) /plugin.json与marketplace.json两处版本号已同步升级(制品不可变)README.md(EN) andREADME_CN.md(中文) both updated and equivalent / 中英文 README 均已更新且语义一致description_i18nhas bothenandzh-CN/description_i18n包含en与zh-CNpython3 scripts/validate.pyandpython3 scripts/build_dist.pypass locally / 本地校验与构建均通过