Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

chore: Externalise intialDelay & period of liveliness probe #1204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kripaliz
Copy link
Contributor

@kripaliz kripaliz commented Oct 4, 2020

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.

Description

Externalise initialDelaySeconds and periodSeconds of liveliness probe.

Motivation and Context

When the video PVC contains a lot of data, hub pod startup seems to take longer. The issue seems to happen when using AWS EFS for PVC, perhaps due to relatively slow IO on EFS. Increasing the initialDelaySeconds helps.

How Has This Been Tested?

Tested this in a cluster where the default initialDelaySeconds wasn't enough and using a higher value gave more time for hub pod to start.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant