ci: add shell: bash to safe-chain install steps#216
Draft
Seth-Schmidt wants to merge 1 commit into
Draft
Conversation
Without `shell: bash`, GitHub Actions runs the step under the default shell which does not apply `set -o pipefail`, so a `curl ... | sh` install where curl fails (e.g. a 404 install URL) silently succeeds. Every other workflow already sets `shell: bash` on this step; align the two that did not: - dependency-safe-chain-check.yml - contracts-confidential-batcher-tests.yml (also bumped the pinned safe-chain version from 1.5.3 to 1.5.8 to match the rest of the repo). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
shell: bashto the safe-chain install step in the twoworkflows that lacked it. Without
shell: bash, the step runs under thedefault shell without
set -o pipefail, so acurl … | shinstall wherecurlfails (e.g. a 404 install URL) silently succeeds defeating themalicious-package guard.
Changes
dependency-safe-chain-check.yml— addshell: bash.contracts-confidential-batcher-tests.yml— addshell: bash, and bump thepinned safe-chain version
1.5.3to1.5.8to match every other workflow.