Skip to content

Conversation

@mayeul-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 4, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is safe to do as integer algorithms often fill the noise and don’t need to propagate carries all the time, to be checked with @tmontaigu

@IceTDrinker
Copy link
Member

if we do this I would keep a max_noise_level, max_noise_level_to_allow_carry_propagation, and probably something similar for the max degree stuff, as the max degree is dictated by parameters

@tmontaigu
Copy link
Contributor

This would'break' max_sum_size as it needs to use the 'true' max degree (i.e the one without the space left for a carry addition)

@IceTDrinker
Copy link
Member

this need a rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants