fix windows csprng seeding when rdseed is not available#3470
Open
mooncitydev wants to merge 1 commit intozama-ai:mainfrom
Open
fix windows csprng seeding when rdseed is not available#3470mooncitydev wants to merge 1 commit intozama-ai:mainfrom
mooncitydev wants to merge 1 commit intozama-ai:mainfrom
Conversation
Made-with: Cursor
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @mooncitydev on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this fixes
ew_seeder() in fhe could panic on Windows whenever no hardware seeder was chosen: x86_64 machines without a working
dseed\ path, and all Windows AArch64 builds, because only \RdseedSeeder\ and \UnixSeeder\ (unix-only) were considered. The library already depends on \getrandom, which implements proper OS entropy on Windows (including AArch64).
This wires the existing \UnixSeeder\ (OS entropy via \getrandom) for \ arget_os = "windows"\ as well, updates the csprng example/bench cfgs, and removes the outdated README/CONTRIBUTING note that said Windows AArch64 was unsupported for lack of entropy.
testing
Could not run \cargo check\ in this environment (no Rust toolchain on PATH). Please run the usual CI / local checks.
made by mooncitydev