chore(lint): remove upgrade false positive warning if new variant add…#3482
Merged
SouchonTheo merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
…ed in an enum versioned
nsarlin-zama
approved these changes
Apr 17, 2026
Contributor
nsarlin-zama
left a comment
nsarlin-zama
left a comment
There was a problem hiding this comment.
Nice and clean fix, thanks a lot!
IceTDrinker
reviewed
Apr 17, 2026
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
Just a small question on my end :)
SouchonTheo
deleted the
ts/lint/fix-false-positive-warning-for-new-enum-added
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove upgrade false positive warning if new variant added
the logic behind is that source can't change but target yes (cf test example)
in that case we need to match with index the old variant names map them with their new possible name
in that case we are guarantee that we avoid false positive
we are also safe because from another linter we know that the naming convention is respected
test were written with the help of AI