Skip to content

Update docs to use blockquote alerts #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wryhder
Copy link
Contributor

@Wryhder Wryhder commented Apr 2, 2025

Follows up on PR #2977.

Per my comment here, the plan is to modify just the docs, not existing articles. (What needs to be highlighted will probably be obvious in some of the articles, but I was thinking there's a risk of highlighting wrongly in articles where I don't have adequate context.)

Please let me know if you have any preferences about how to approach this.

@Wryhder Wryhder marked this pull request as draft April 2, 2025 03:18
@psiinon
Copy link
Member

psiinon commented Apr 2, 2025

Logo
Checkmarx One – Scan Summary & Details31e78060-84d8-42d1-a62f-fa0f2e0dc25e

Great job, no security vulnerabilities found in this Pull Request

@psiinon
Copy link
Member

psiinon commented Apr 2, 2025

That one looks good 😁
TBH I dont have a list of pages I think should be changed - I was planning on just changing things as I noticed them!
I already added one here https://www.zaproxy.org/faq/somethings-not-working-what-should-i-do/#raise-an-issue

Note that everything in the Desktop User Guide is generated from Java Help, so changing that will not be so easy. We could put some special strings in the help which we would then convert, but it will require more work.

@Wryhder
Copy link
Contributor Author

Wryhder commented Apr 2, 2025

TBH I dont have a list of pages I think should be changed - I was planning on just changing things as I noticed them!
I already added one here https://www.zaproxy.org/faq/somethings-not-working-what-should-i-do/#raise-an-issue

Got it. Also, looks good. 👍

Note that everything in the Desktop User Guide is generated from Java Help, so changing that will not be so easy. We could put some special strings in the help which we would then convert, but it will require more work.

Yeah, I remember @thc202 said 90% of the docs are generated from help content. I'll explore your suggestion to use special strings within the next couple of weeks.

@psiinon
Copy link
Member

psiinon commented Apr 2, 2025

FYI we use 3rd party lib to do the conversion, but then we have some of our own custom code in https://github.com/zaproxy/zap-admin/tree/master/buildSrc/src/main/java/org/zaproxy/gradle/website
We would need to define some sort of convention for the blockquote alerts which doesnt break the Java Help but which is then recognised by our conversion code.
That make sense?

@Wryhder
Copy link
Contributor Author

Wryhder commented Apr 3, 2025

That makes sense! I’ll keep you posted if I run into any issues once I get started.

@Wryhder
Copy link
Contributor Author

Wryhder commented Apr 3, 2025

@kingthorin @psiinon Please see my comment here about updating the alert template.

(Made it in a merged/closed PR, so was thinking you might miss it.)

@psiinon
Copy link
Member

psiinon commented Apr 7, 2025

@Wryhder I think your suggestions would be cleaner - so v happy for you to create a shortcode, or whatever you think would be best 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants