-
Notifications
You must be signed in to change notification settings - Fork 115
Update docs to use blockquote alerts #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: chibbyalucard <[email protected]>
Great job, no security vulnerabilities found in this Pull Request |
That one looks good 😁 Note that everything in the Desktop User Guide is generated from Java Help, so changing that will not be so easy. We could put some special strings in the help which we would then convert, but it will require more work. |
Got it. Also, looks good. 👍
Yeah, I remember @thc202 said 90% of the docs are generated from help content. I'll explore your suggestion to use special strings within the next couple of weeks. |
FYI we use 3rd party lib to do the conversion, but then we have some of our own custom code in https://github.com/zaproxy/zap-admin/tree/master/buildSrc/src/main/java/org/zaproxy/gradle/website |
That makes sense! I’ll keep you posted if I run into any issues once I get started. |
@kingthorin @psiinon Please see my comment here about updating the alert template. (Made it in a merged/closed PR, so was thinking you might miss it.) |
@Wryhder I think your suggestions would be cleaner - so v happy for you to create a shortcode, or whatever you think would be best 😁 |
Follows up on PR #2977.
Per my comment here, the plan is to modify just the docs, not existing articles. (What needs to be highlighted will probably be obvious in some of the articles, but I was thinking there's a risk of highlighting wrongly in articles where I don't have adequate context.)
Please let me know if you have any preferences about how to approach this.