feat: item & maps in frame rendering #243
Open
+238
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Wow, I'm kind of impressed. Very cool, seems you understand the code base very well :) Will make sure to answer your questions in a few days |
zardoy
requested changes
Dec 23, 2024
Phoenix616
force-pushed
the
pr/itemframe-maps
branch
3 times, most recently
from
266eb20 to
3db17c5
Compare
Phoenix616
force-pushed
the
pr/itemframe-maps
branch
from
3db17c5 to
b3d932f
Compare
…m models This includes disposing of remove item/map meshes of item frames
zardoy
requested changes
Jan 16, 2025
|
Item Frame rendering including maps and items should work properly now. |
|
/deploy |
|
/deploy |
|
Deployed to Vercel Preview: https://prismarine-ignkb77r2-zaro.vercel.app |
It doesn't work correctly on all versions (eg rotation on 1.21). Do you have a server with via backwards to test on all versions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for rendering item frames including the items in it.
What works:
What doesn't work: